Update help message of jj edit, add FAQ on idiomatic change switching
#3250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveklabnik
approved these changes
Mar 7, 2024
PhilipMetzger
requested changes
Mar 7, 2024
martinvonz
reviewed
Mar 7, 2024
martinvonz
reviewed
Mar 7, 2024
martinvonz
reviewed
Mar 8, 2024
This change updates the language of `jj edit`'s help message to be more clear as to the nature of the command. It also adds a recommendation for a more idiomatic/safer workflow.
martinvonz
reviewed
Mar 13, 2024
martinvonz
approved these changes
Mar 14, 2024
|
Idk if I would be able to hit merge with the approval or not, but it looks like @PhilipMetzger's request for changes is still active? I'm good for this to merge. |
|
Yeah, looks like I can't be the one to merge even now. Whenever you're good, feel free! |
You should have permission now :) |
|
Sweet, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the language of
jj edit's help message to be more clear as to the nature of the command. It also adds a recommendation for a more idiomatic/safer workflow. This recommendation is also elaborated in a new FAQ entry.Checklist
If applicable:
CHANGELOG.md